Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Windows version #110

Conversation

GuillaumeBernardFGTech
Copy link
Contributor

Hello, thank you for this awesome tool!

As I'm stuck on windows at work, and not allowed to install WSL, I created the necessary powershell script and compiled the tool for windows.

It really helps me and my colleagues in our day to day work, so we decided to clean it up and submit this PR to help others.
I use it since 2 month on windows 10 and 11, using windows terminal with powershell 7, it works great. It's even better with Ho My Posh and the kubectl segment to display the current context in the prompt

What I changed

  • Makefile: add Windows AMD64 build
  • Github CI: add Windows binary to the release
  • Completion.go: Add cobra autocompletion for powershell
  • Init.go: add powershell script
  • Documentation: add install instructions for windows

Related issues

@GuillaumeBernardFGTech
Copy link
Contributor Author

GuillaumeBernardFGTech commented Feb 9, 2024

For your information, windows defender on my work computer blocks the version 0.8.1 with a low severity. I don't know why. The 0.8.0 works.
On my personnal computer, also using windows defender, I do'nt have the problem, both versions work.

@zerr0s
Copy link

zerr0s commented Mar 8, 2024

it would be nice to get a release for all windows users !!

@ilyesfhi
Copy link

ilyesfhi commented Mar 8, 2024

Great job 🔥 ! I hope it will be released soon.

@GuillaumeBernardFGTech
Copy link
Contributor Author

Is the maintainer of the project still here?

@guillaumebernard84
Copy link

Commenting with my personnal account to get notifications on this pull request

@danielfoehrKn
Copy link
Owner

danielfoehrKn commented Apr 14, 2024

Thank you for the awesome commit, highly appreciated. Apologize for the long wait. Due to my inactivity, some changes piled up including Linux ARM support which caused merged conflicts when I worked on them in-order. Knowing that it has been a while that you have authored that commit I did not want to bother you with resolving these merge conflicts. I squashed all of your commits into one, resolved the conflicts, added you as commiter and author and pushed the changes to master here. I hope that is ok with you (you still show up as the author of the commit in Github).

I will also do the necessary changes on the Homebrew side of things and link them here (realized that homebrew is not natively supported on windows, so removed it from the homebrew action here). As your changes are now on master, I'll close this PR and thank you for your patience.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support for MS Windows
5 participants