Support preference for all types of GKE endpoints #158
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BadLiveware
force-pushed
the
support-all-endpoints
branch
from
0b3b8b0 to
f05e3f8
Compare
BadLiveware
force-pushed
the
support-all-endpoints
branch
from
f05e3f8 to
807ba4c
Compare
|
Changes look good, but fails CI checks - could you have another look? Thank you! |
Fixed |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
GKE supports 3 different types of endpoints, DNS, Private IP, and public IP.
Clusters created before a certain time will still have a public IP at
cluster.Endpointeven when they are configured for private endpoints. This allows these clusters to select the different types even ifcluster.Endpointis something else.Afaik, newer clusters will have the correct
cluster.Endpointso by default we can use that