Add RAD_TELEMETRY_DISABLED to fix compilation errors #48
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danielga
force-pushed
the
master
branch
2 times, most recently
from
feae357
to
5cc4ce0
Compare
danielga
changed the title
danielga
approved these changes
May 26, 2020
|
Only the |
|
I think definition of RAD_TELEMETRY_DISABLED required for non-windows too, it throws same missing file error on Linux. |
|
Yeah, I have that on x86-64 branch, need to backport it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When trying to compile the mathlib, it's missing fieldtype_t and string_t for things such as variant_t.h
I haven't seen any compilation failures for the other inclusions regarding these, so I shoved this into the premake file.
Also, when compiling on windows, telemetry needs to be disabled for it to compile. A file being included by the vprof_telemetry.h is missing: "../../thirdparty/telemetry/include/telemetry.h"