ChartData.removeEntryByXIndex removes the wrong entry

[dorsoft]

scenario:

1. ChartData contains 1 dataset with 10 values (xIndex 0-9)
2. Call ChartData.removeEntryByXIndex(xIndex:10, datasetIndex:0)
   Expected result: no entry is removed and the method returns false
   Actual result: the entry at xIndex 9 is removed, repeated method calls remove the last index (8,7,6...)

The fix:

public func removeEntryByXIndex(xIndex: Int, dataSetIndex: Int) -> Bool
{
if (dataSetIndex >= _dataSets.count)
{
return false
}

var entry = _dataSets[dataSetIndex].entryForXIndex(xIndex)

if (entry?.xIndex != xIndex) {
return false
}

return removeEntry(entry, dataSetIndex: dataSetIndex)
}

[danielgindi]

How exactly does constraining dataSetIndex solve this issue?... If at all, you would want to constrain the xIndex. But that is already done by check for the right xIndex in case that it does not exist and we got the closest one.

[dorsoft]

I've added:
if (entry?.xIndex != xIndex) {
return false
}

[dorsoft]

sorry for not mentioning it

[danielgindi]

@dorsoft Oh now it makes sense. But shouldn't you check for nil first?

[dorsoft]

you are right

if (entry == nil || entry?.xIndex != xIndex) {
return false
}

[danielgindi]

@dorsoft Actually - my bad! It's Swift. It will check the optional for you when using an if. Your previous post was correct :)

[danielgindi]

@dorsoft Do you want to open a PR? I'm not in front of Mac. Please format it according to the surrounding coding style and have a clean commit/PR :)

[dorsoft]

Done

[danielgindi]

#185