Run view port jobs afterwards (Fixes #2395) #2396
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`notifyDataSetChanged()` may actually mutate some of the view port properties — stomping all over what the view port jobs just accomplished. This behavior is apparent when calling `moveViewToX()` on the chart view that has no frame yet. Prior to this change, calling `moveViewToX()` had no affect on a chart a chart that has no frame. That's because once the chart view was assigned a frame, `notifyDataSetChanged()` call would actually mutate the view port's properties stomping all over what the view port jobs just finished doing.
Codecov Report
@@ Coverage Diff @@
## master #2396 +/- ##
==========================================
- Coverage 19.66% 19.65% -0.01%
==========================================
Files 112 112
Lines 13712 13714 +2
==========================================
Hits 2696 2696
- Misses 11016 11018 +2
Continue to review full report at Codecov.
|
PeterSrost
pushed a commit
to sokol8/Charts
that referenced
this pull request
Oct 31, 2018
…terwards Run view port jobs afterwards (Fixes ChartsOrg#2395)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
notifyDataSetChanged()may actually mutate some of the view port properties — stomping all over what the view port jobs just accomplished.This behavior is apparent when calling
moveViewToX()on the chart view that has no frame yet. Prior to this change, callingmoveViewToX()had no affect on a chart a chart that has no frame. That's because once the chart view was assigned a frame,notifyDataSetChanged()call would actually mutate the view port's properties stomping all over what the view port jobs just finished doing.