Conform to macOS api changes in swift 3.2 #2717
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #2717 +/- ##
=======================================
Coverage 19.65% 19.65%
=======================================
Files 112 112
Lines 13717 13717
=======================================
Hits 2696 2696
Misses 11021 11021
Continue to review full report at Codecov.
|
|
We will hold all Xcode 9 PRs after it's released. |
|
in xcode 9 beta 6 there is no warnings but there this is more swifty. |
PeterSrost
pushed a commit
to sokol8/Charts
that referenced
this pull request
Oct 31, 2018
Conform to macOS api changes in swift 3.2
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Compiling the framework with Xcode 9 beta 4 results in error due to macOS Swift api changes.
This pull request resolves that.