Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

minor bug fix in favor of 3.1 release #3312

Merged
merged 2 commits into from
Mar 4, 2018
Merged

minor bug fix in favor of 3.1 release #3312

merged 2 commits into from
Mar 4, 2018

Conversation

liuxuan30
Copy link
Member

@liuxuan30 liuxuan30 commented Mar 2, 2018

Will pick a few before releasing 3.1

  1. revert a mistake, fix Bug in ZoomViewJob? #3299
  2. add one more key for iOS 11 camera roll saving. fix Save picture crash in demos on iOS 11+ #3311

@liuxuan30 liuxuan30 requested a review from jjatie March 2, 2018 00:20
@liuxuan30 liuxuan30 added this to In progress in 3.1 release Mar 2, 2018
@codecov-io
Copy link

codecov-io commented Mar 2, 2018

Codecov Report

Merging #3312 into master will not change coverage.
The diff coverage is 0%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #3312   +/-   ##
=======================================
  Coverage   28.32%   28.32%           
=======================================
  Files         117      117           
  Lines       15669    15669           
  Branches      320      320           
=======================================
  Hits         4438     4438           
  Misses      11188    11188           
  Partials       43       43
Impacted Files Coverage Δ
Source/Charts/Jobs/ZoomViewJob.swift 0% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e29536b...df018a4. Read the comment docs.

@liuxuan30 liuxuan30 merged commit 0ceab4e into master Mar 4, 2018
3.1 release automation moved this from In progress to Done Mar 4, 2018
@danielgindi danielgindi deleted the bugfix branch January 23, 2020 13:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
3.1 release
  
Done
Development

Successfully merging this pull request may close these issues.

Save picture crash in demos on iOS 11+ Bug in ZoomViewJob?
2 participants