Swift 4.1 #3370
Swift 4.1 #3370
Conversation
added a workspace to include all demos with the project to make it easier to test changes
|
@liuxuan30 Here is the Swift 4.1 update. You can bump to Charts 3.1.1 now |
|
Sorry if I'm being a dumb newbie, but when I run 'pod update' for Charts it pulls version 3.1.0 and I still have the compilation warnings about ! and flatMap. If I edit the podfile to try and force version 3.1.1 it says it does not exist. Am I doing something wrong? |
|
The pod hasn't been updated yet. 3.1.1 will be out when @liuxuan30 has time. |
|
Ah! That would explain it! Thanks |
|
sure. Thanks. I will handle maybe tomorrow. |
| @@ -1,12 +1,12 @@ | |||
| language: objective-c | |||
| osx_image: xcode9 | |||
| osx_image: xcode9.3beta | |||
There was a problem hiding this comment.
Probably should drop the "beta", but it will work for now.
| @@ -1045,7 +1051,7 @@ | |||
| IPHONEOS_DEPLOYMENT_TARGET = 9.0; | |||
| LD_RUNPATH_SEARCH_PATHS = "$(inherited) @executable_path/Frameworks"; | |||
| PRODUCT_BUNDLE_IDENTIFIER = "com.dcg.$(PRODUCT_NAME:rfc1034identifier)"; | |||
| PRODUCT_NAME = ChartsDemo; | |||
| PRODUCT_NAME = "ChartsDemo-iOS"; | |||
There was a problem hiding this comment.
did we changed the project strut, by purpose or accident?
There was a problem hiding this comment.
On purpose. Some naming was out of date, or inconsistent (macOS vs OS X).
| @@ -1691,12 +1691,12 @@ open class BarLineChartViewBase: ChartViewBase, BarLineScatterCandleBubbleChartD | |||
| } | |||
|
|
|||
| /// - returns: The DataSet object displayed at the touched position of the chart | |||
| @objc open func getDataSetByTouchPoint(point pt: CGPoint) -> IBarLineScatterCandleBubbleChartDataSet! | |||
| @objc open func getDataSetByTouchPoint(point pt: CGPoint) -> IBarLineScatterCandleBubbleChartDataSet? | |||
There was a problem hiding this comment.
is this warned by Xcode 9.3? or why we change
| @@ -0,0 +1,8 @@ | |||
| <?xml version="1.0" encoding="UTF-8"?> | |||
There was a problem hiding this comment.
Xcode 9.3 adds a new IDEWorkspaceChecks.plist file to a workspace's shared data, to store the state of necessary workspace checks. Committing this file to source control will prevent unnecessary rerunning of those checks for each user opening the workspace. (37293167)
| CLANG_WARN_DIRECT_OBJC_ISA_USAGE = YES_ERROR; | ||
| CLANG_WARN_EMPTY_BODY = YES; | ||
| CLANG_WARN_ENUM_CONVERSION = YES; | ||
| CLANG_WARN_INFINITE_RECURSION = YES; | ||
| CLANG_WARN_INT_CONVERSION = YES; | ||
| CLANG_WARN_NON_LITERAL_NULL_CONVERSION = YES; | ||
| CLANG_WARN_OBJC_IMPLICIT_RETAIN_SELF = YES; |
There was a problem hiding this comment.
is this added by xcode automatically?
There was a problem hiding this comment.
New Xcode recommended settings
|
good. I'm pushing 3.1.1 to pod now |
|
Looks good, many thanks |
Moved to Swift 4.1 and Xcode 9.3