Add more render options for y axis labels #3406
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #3406 +/- ##
========================================
Coverage ? 29.2%
========================================
Files ? 117
Lines ? 13306
Branches ? 0
========================================
Hits ? 3886
Misses ? 9420
Partials ? 0
Continue to review full report at Codecov.
|
danielgindi
added a commit
that referenced
this pull request
Jan 23, 2020
+ also consider other renderers Fixes #3406
IncredibleStar
added a commit
to IncredibleStar/daniel-charts
that referenced
this pull request
May 26, 2021
+ also consider other renderers Fixes ChartsOrg/Charts#3406
rcblue
added a commit
to rcblue/Charts
that referenced
this pull request
Jan 6, 2023
+ also consider other renderers Fixes ChartsOrg/Charts#3406
SwiftPolar
pushed a commit
to SwiftPolar/Charts
that referenced
this pull request
Mar 20, 2023
+ also consider other renderers Fixes ChartsOrg#3406
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Goals ⚽
If the user chooses not to display the inner web, the adjusted x position for y axis labels in a
RadarChartView()looks off, therefore this commit introduces two additional properties that allow for centering these labels.Implementation Details 🚧
The renderer used a hardcoded value of
10.0points to shift the labels to the right, this has been changed to include a new property (labelXOffset) to let the user configure this value for their needs.The
NSTextAlignmentfor rendering the labels was also hardcoded to.left, I've introduced a new property calledlabelAlignmentto allow users to configure this if needed.Both of the previously hardcoded values have been set as the default value for the newly added properties.
Testing Details 🔍
No testing has been added as part of these changes.