Make NSUIAccessibilityElement initializer public. #3654
Conversation
Codecov Report
@@ Coverage Diff @@
## master #3654 +/- ##
=======================================
Coverage 31.06% 31.06%
=======================================
Files 114 114
Lines 10465 10465
=======================================
Hits 3251 3251
Misses 7214 7214
Continue to review full report at Codecov.
|
| @@ -33,7 +33,7 @@ open class NSUIAccessibilityElement: UIAccessibilityElement | |||
| } | |||
| } | |||
|
|
|||
| override init(accessibilityContainer container: Any) | |||
| override public init(accessibilityContainer container: Any) | |||
There was a problem hiding this comment.
shall we change it to open? @petester42 @jjatie
|
I’ll look into it. Anything that is nsui prefixed is usually just for internal use since it’s platform dependent switch to have to same API. I’m hesitant to merge because it should be internal only. |
|
After some thought. I can see the usefulness of this to be public. |
3 similar comments
|
After some thought. I can see the usefulness of this to be public. |
|
After some thought. I can see the usefulness of this to be public. |
|
After some thought. I can see the usefulness of this to be public. |
|
After some thought. I can see the usefulness of this to be public. |
Issue Link 🔗
When I create custom renderer with overriding LineChartRenderer, I can't create
NSUIAccessibilityElementinstance because its initializer is not public!Furthermore, although
NSUIAccessibilityElementis defined as open class, its subclass can create no instance.Goals ⚽
To be able to create
NSUIAccessibilityElementinstance outside Charts.framework.Implementation Details 🚧
publicmodifier toNSUIAccessibilityElement.init(accessibilityContainer:).Testing Details 🔍
None, there are no specific tests.
This should not effect the snapshotting at all, and has no effect on the existing codebase.