Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make the ChartXAxisRenderer more flexible: now possible to overwrite drawing the line or label of the ChartLimitLine #432

Merged
merged 5 commits into from
Oct 8, 2015

Conversation

pajai
Copy link

@pajai pajai commented Sep 29, 2015

Hi Daniel,

I have done a few refactorings of the ChartXAxisRenderer that allow the following:

  • Now possible to extend the renderer and overwrite selectively the label or line drawing method for a ChartLimitLine (in my project I needed e.g. to draw a triangle as arrow at the top in one case or a short line at the bottom as well as change the label offset, now easily possible)
  • Functionally does the same as before
  • I have eased the visibility of ChartAxisRendererBase#transformer (easier syntax when extending ChartXAxisRenderer) and ChartUtils#drawText (possible to call the method from the ChartXAxisRenderer extension).

Thanks!
Cheers,
Patrick

@danielgindi
Copy link
Collaborator

@pajai this seems great! I would have automatically merged your PR, but in a few lines there are stray brackets... Please fix code styling to match the rest of the code and then I'll merge it in!

@pajai
Copy link
Author

pajai commented Oct 1, 2015

Sure. I’ll fix the styling as soon as I come to the office tomorrow. Cheers,

@pajai pajai closed this Oct 2, 2015
@pajai pajai reopened this Oct 2, 2015
@pajai
Copy link
Author

pajai commented Oct 2, 2015

Hi Daniel, I did the code styling tuning (the last commit should be part of this pul request). Cheers & thanks!

danielgindi added a commit that referenced this pull request Oct 8, 2015
Make the ChartXAxisRenderer more flexible: now possible to overwrite drawing the line or label of the ChartLimitLine
@danielgindi danielgindi merged commit 10fbd96 into ChartsOrg:master Oct 8, 2015
@pajai
Copy link
Author

pajai commented Oct 8, 2015

Thx! There is also a similar pull request for the Android project. Cheers,

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants