Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SPM GitHub Action #4553

Merged
merged 4 commits into from
Jan 12, 2021
Merged

SPM GitHub Action #4553

merged 4 commits into from
Jan 12, 2021

Conversation

jjatie
Copy link
Collaborator

@jjatie jjatie commented Jan 12, 2021 •
edited

Issue Link πŸ”—

Resolves #4539 and #4550

Goals ⚽

Fix SwiftPM build, and add a GitHub Action to help ensure it is always buildable

Implementation Details 🚧

Added typealiases in Platform.swift rather than add #if in many files for cross-platform support

Testing Details πŸ”

Github Actions run swift build to ensure it builds

@codecov-io
Copy link

Codecov Report

Merging #4553 (ddd8af9) into master (0aa2b76) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #4553   +/-   ##
=======================================
  Coverage   58.96%   58.96%           
=======================================
  Files          50       50           
  Lines         290      290           
=======================================
  Hits          171      171           
  Misses        119      119
Impacted Files Coverage Ξ”
Source/Charts/Charts/BarLineChartViewBase.swift 100.00% <ΓΈ> (ΓΈ)
Source/Charts/Charts/PieChartView.swift 100.00% <ΓΈ> (ΓΈ)
Source/Charts/Components/MarkerView.swift 0.00% <ΓΈ> (ΓΈ)
Source/Charts/Renderers/BarChartRenderer.swift 100.00% <ΓΈ> (ΓΈ)
.../Charts/Renderers/HorizontalBarChartRenderer.swift 100.00% <ΓΈ> (ΓΈ)
Source/Charts/Renderers/PieChartRenderer.swift 100.00% <ΓΈ> (ΓΈ)
Source/Charts/Renderers/XAxisRenderer.swift 100.00% <ΓΈ> (ΓΈ)
Source/Charts/Charts/ChartViewBase.swift 100.00% <100.00%> (ΓΈ)
Source/Charts/Components/Description.swift 100.00% <100.00%> (ΓΈ)
Source/Charts/Components/YAxis.swift 100.00% <100.00%> (ΓΈ)

Continue to review full report at Codecov.

Legend - Click here to learn more
Ξ” = absolute <relative> (impact), ΓΈ = not affected, ? = missing data
Powered by Codecov. Last update 0aa2b76...ddd8af9. Read the comment docs.

@jjatie jjatie marked this pull request as ready for review January 12, 2021 14:14
@jjatie jjatie requested a review from liuxuan30 January 12, 2021 14:17
@jjatie jjatie merged commit dea1cc5 into master Jan 12, 2021
@jjatie jjatie deleted the spm-github-action branch January 12, 2021 14:17
This was referenced Jan 12, 2021
Closed
Closed
ccworld1000 added a commit to ccworld1000/Charts that referenced this pull request Jan 13, 2021
@ccworld1000
Merge pull request #10 from danielgindi/master
7891a36 
SPM GitHub Action (ChartsOrg#4553)
@andyj-at-aspin
Copy link

andyj-at-aspin commented Jan 13, 2021 •
edited

How about a 4.0.1 pre-release so that the iOS-based users can test for the 4.x changes as well without pulling master? @liuxuan30 ?

@liuxuan30
Copy link
Member

@andyj-at-aspin what is your point here? I'm a little confused as we have 4.0 released so you can test it? or you mean the new merges? like #4497

@andyj-at-aspin
Copy link

andyj-at-aspin commented Jan 28, 2021 •
edited

I mean please create a numbered release that includes changes to master such as this specific commit. Before this commit, it was not possible to test Charts 4.x using SPM installation targeting iOS at all. After this commit, it's been possible as long as you tell SPM to use the master branch inside Xcode. It's not possible to do this if Charts is added as a sub-dependency of another Swift Package.

@liuxuan30
Copy link
Member

sure. I will address it recently. Need to merge another PR and fix the CI failures

@hixfield
Copy link

I can build just fine now when pointing the SPM to the master branch. But indeed, an minor 4.0.1 tag would be much nicer.

@jjatie jjatie mentioned this pull request Feb 9, 2021
Closed
@andyj-at-aspin
Copy link

It's been a while since I last verified my Swift Package versions in my Apps. Thank you everyone concerned with the 4.0.1 release - especially Jacob and Xuan.

abhiramvadlapatla pushed a commit to abhiramvadlapatla/Charts that referenced this pull request Dec 21, 2021
@jjatie @abhiramvadlapatla
SPM GitHub Action (ChartsOrg#4553)
4498c82 
* Create swift.yml

* Update project so SPM builds for all platforms

* Fix AutoreleaseingUnsafePointer warning

* Remove tests from github SPM action
zebraciam added a commit to zebraciam/Charts that referenced this pull request Jul 6, 2022
@zebraciam
Merge branch 'master' into ZebraFork
6531764 
* master:
  update changelog.
  Fixed incorrect guard return statement when rendering limit lines (ChartsOrg#4563)
  Fix bounds checks on binary search (ChartsOrg#4577)
  Added SPM build action (ChartsOrg#4576)
  Replace FBSnapshotTestCase with pointfree/swift-snapshot-testing (ChartsOrg#4574)
  Import swift algorithms (ChartsOrg#4497)
  ChartViewBase cleanup (ChartsOrg#4537)
  SPM GitHub Action (ChartsOrg#4553)
  Algorithm updates (ChartsOrg#3638)
  Added SPM Install section
  Update README.md
  Fix missing drawIconsEnabled parameter initialization in the copying constructor of the ChartBaseDataSet (ChartsOrg#4424)
  Resolve conflict for 4.0 branch and master (ChartsOrg#4456)
  Alternative for SPM dynamic linking (ChartsOrg#4478)
  3.6.0 changelog

# Conflicts:
#	Source/Charts/Renderers/LineChartRenderer.swift
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@liuxuan30 liuxuan30 Awaiting requested review from liuxuan30

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@jjatie @codecov-io @andyj-at-aspin @liuxuan30 @hixfield