Replace FBSnapshotTestCase with pointfree/swift-snapshot-testing #4574
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use github actions for testing
|
wow, thank you!!! |
|
anything we need to keep in mind for this new framework? like a cheat sheet? |
|
Only issue I've run into (which is true in FBSnapshot too) is that Intel and Silicon Macs generate slightly different snapshots. I've written a method There are many more options for snapshotting available in the library, beyond just images. Their GitHub page references the videos where they walkthrough creating the framework and using it. |
abhiramvadlapatla
pushed a commit
to abhiramvadlapatla/Charts
that referenced
this pull request
Dec 21, 2021
…rtsOrg#4574) * Replace FBSnapshotTestCase with pointfree/SnapshotTesting Use github actions for testing * Added iOS Snapshots * Update tests for SPM * Add snapshots for x86 and Silicon * Use Charts scheme for testing * Remove Carthage search paths * Fix x86 snapshots directory name * Clean iOS and tvOS tests before testing * Added action for building the iOS demo
zebraciam
added a commit
to zebraciam/Charts
that referenced
this pull request
Jul 6, 2022
* master: update changelog. Fixed incorrect guard return statement when rendering limit lines (ChartsOrg#4563) Fix bounds checks on binary search (ChartsOrg#4577) Added SPM build action (ChartsOrg#4576) Replace FBSnapshotTestCase with pointfree/swift-snapshot-testing (ChartsOrg#4574) Import swift algorithms (ChartsOrg#4497) ChartViewBase cleanup (ChartsOrg#4537) SPM GitHub Action (ChartsOrg#4553) Algorithm updates (ChartsOrg#3638) Added SPM Install section Update README.md Fix missing drawIconsEnabled parameter initialization in the copying constructor of the ChartBaseDataSet (ChartsOrg#4424) Resolve conflict for 4.0 branch and master (ChartsOrg#4456) Alternative for SPM dynamic linking (ChartsOrg#4478) 3.6.0 changelog # Conflicts: # Source/Charts/Renderers/LineChartRenderer.swift
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
FBSnapshotTestCase is all but deprecated. pointfree's snapshotting library is an excellent replacement that's become a bit of a community standard for snapshot testing. This also removes our Carthage dependency for tests.
Use github actions for testing. They consistent run faster, require less setup and satisfy our needs.