Fix issue related to PhilJay/MPAndroidChart#1121 #488
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
commit 088b10d actually want it to be 1 |
|
If it will be zero then it will cause an infinite loop. Should be closed |
|
Should not cause infinite loop. You already fixed this: https://github.com/danielgindi/ios-charts/blob/master/Charts/Classes/Renderers/RadarChartRenderer.swift#L182 Currently it will (per default) skip 1 web line. |
|
Oh right. This property was very confusing to begin with... |
danielgindi
added a commit
that referenced
this pull request
Oct 21, 2015
Fix issue related to PhilJay/MPAndroidChart#1121
|
Yes it was :-) |
|
Yeah there was a good reason why I wanted to change its behavior to not add/subtract the 1 on the property. There were many bugs and misunderstandings. I hope its stable now... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Setting default skip to 1 might result in unexpected behaviour.