if only line data exists and no other data, turn _deltaX to 1.0 #493
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… like what LineChartView did
danielgindi
added a commit
that referenced
this pull request
Oct 23, 2015
if only line data exists and no other data, turn _deltaX to 1.0
|
Thanks! Please have your descriptions more to-the-point next time :-) It's hard to understand what the change actually does... |
|
OK. The problem is sometimes there is only line chart data, no bubble, no bar, no candle. So the _deltaX is not correct. This fix it, taking example from LineChartView |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
if only line data exists and no other data in combined chart, turn _deltaX to 1.0, just like what LineChartView did
This is for #329 and what @jwardle asked in my PR #269