update to Swift 4.2, Realm 3.11.1 #24
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…work is not Swift 4.2 at this moment we update)
liuxuan30
requested review from
danielgindi and
pmairoldi
and removed request for
danielgindi
|
@petester42 Xcode warns two self-calling init(). I guess it's a typo that you missed to use another similar function :) but anyway, please have a look |
|
seems CI passed smoothly. should be no risk to merge now |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
update to Swift 4.2, Realm 3.11.1 (compiled from source, binary framework is not Swift 4.2 at this moment we update)
Fixed warnings and infinite loop of some convenient init functions