-
-
Notifications
You must be signed in to change notification settings - Fork 226
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use cibuildwheel to build and test wheels #805
Use cibuildwheel to build and test wheels #805
Conversation
d88fbaf
to
ef23f60
Compare
Thanks for the PR @zariiii9003. I'm not experienced with all this CI stuff. Can you have a look on why this tests are failing? I can't tell why it happens. https://github.com/danielhrisca/asammdf/actions/runs/3804656101/jobs/6472027912 |
Never mind I think it was just some failed test |
Yes, two windows test are failing, but they are failing locally, too:
|
I've fixed the tests. Can you resolve the new conflicts? |
ef23f60
to
754f3d3
Compare
052eccf
to
8477d5e
Compare
There's a sphinx warning |
I think you should run black and isort again. |
Thank you Artur! |
This is just a suggestion, feel free to close it.
It looks like a huge change, but i had to move
asammdf
intosrc
. Otherwise pytest would try to test the repository code instead of the built and installed wheels. This would fail because there is nocutil
binary in the repository. With theasammdf
folder hidden insrc
, it works fine.The git history of all the moved files should remain untouched.
I see that you had the same issue and just put
usedevelop = true
into the tox.ini file. But that is not really a solution for the problem, because it does not test the source distribution.