Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

self gravitating disc setup gives icooling=1 when it should give icooling=3 #114

Closed
raomoomoo opened this issue Mar 11, 2021 · 1 comment
Closed

self gravitating disc setup gives icooling=1 when it should give icooling=3 #114

raomoomoo opened this issue Mar 11, 2021 · 1 comment
Assignees
@danieljprice
Labels
invalid This doesn't seem right

Comments

@raomoomoo
Copy link

icooling is 1 by default with make SETUP = sgdisc
@danieljprice danieljprice self-assigned this Mar 11, 2021
@danieljprice
Copy link
Owner

confirmed, I think Gammie cooling was originally icooling=1 but is now icooling=3, so the disc setup should reflect this

@danieljprice danieljprice added the invalid This doesn't seem right label Mar 11, 2021
benedettaveronesi pushed a commit to benedettaveronesi/phantom that referenced this issue Feb 16, 2023
danieljprice#114 fixing default cooling in disc_setup
26feec8
s-neilson pushed a commit to s-neilson/phantom that referenced this issue Mar 18, 2023
danieljprice#114 fixing default cooling in disc_setup
ee4eebe
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@danieljprice danieljprice

Labels
invalid This doesn't seem right
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@danieljprice @raomoomoo