Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MPI and OpenMP tests only cover limited number of threads/tasks #231

Closed
conradtchan opened this issue Feb 15, 2022 · 0 comments · Fixed by #217
Closed

MPI and OpenMP tests only cover limited number of threads/tasks #231

conradtchan opened this issue Feb 15, 2022 · 0 comments · Fixed by #217

Comments

@conradtchan
Copy link
Collaborator

MPI tests run on 2 tasks, and OpenMP tests run on 1 thread. This does not fully test parallel behaviour.

Tests should cover up to 4 MPI tasks and 4 OpenMP threads.
@conradtchan conradtchan mentioned this issue Feb 15, 2022
Merged
conradtchan added a commit that referenced this issue Feb 17, 2022
@conradtchan
Test all setups with MPI in the workflow (#217)
e2b7bcd 
Currently, only the testkd setup is tested against MPI. There is also a bug in the action that causes DEBUG=yes to not be tested. This PR adds every test from the serial tests.

 - ['test', '']
 - ['testkd', '']
 - ['testdust', 'dust']
 - ['testgr', 'gr']
 - ['testgrav', 'gravity ptmass']
 - ['testgrowth', 'dustgrowth']
 - ['testnimhd', 'nimhd']
 - ['test2', '']
 - ['testcyl', '']

Resolves #210

Resolves #231 by testing:

4 OpenMP tasks - to lift any degeneracies encountered with 2
4 MPI tasks - to lift any degeneracies encountered with 2
1 MPI task the trivial case, which should be functionally the same as a non-MPI run, but includes a global tree building step
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Test all setups with MPI in the workflow ADACS-Australia/phantom
1 participant
@conradtchan