MPI-compatible direct sum gravity test #220
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
because they are very close, and changing the order of addition can cause the test to fail
due fxyz_ptmass and fxyz_ptmass_gas being allocated different sizes, the slice needs to be specified explicitly
and tidy formatting
danieljprice
approved these changes
Feb 10, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of PR:
Bug fix
Description:
directsum_grav, the routine for calculating the gravitational force via direct summation is not MPI aware, and will give incorrect results when particles are distributed over multiple MPI tasks.This PR shuffles all the particles onto the master task to calculate the direct summation, before allowing derivs to redistribute the particles across the MPI tasks. Care is taken to sort the particles by ID so that the test compares the results of the same particles.
Fixes #219
Testing:
Did you run the bots? yes