Fixes to the bots.sh pre-commit action #317
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
require bots script to run in serial because AUTHORS creation is not threadsafe
s-neilson
pushed a commit
to s-neilson/phantom
that referenced
this pull request
Mar 18, 2023
* allow multiple files to be passed to bots script require bots script to run in serial because AUTHORS creation is not threadsafe * fix: don't filter out author file * optimisation: no need to check if file is in git if using pre-commit
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of PR:
Bug fix
Description:
require_serial: true.pre-commit-config.yamlformatting--fileoption was being processed. Now takes a list of filesbots.shscript was being runget_only_files_in_git(), because files are already in git (or will be in git) if they are being handled by pre-commit.Testing:
Source files were manually changed to violate the bots rules, and confirmed that this blocked the commit. Run time is only a few seconds, which shows that the script is only being run on the relevant files.
Did you run the bots? yes