Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Damping bcs #351

Merged
merged 4 commits into from
Feb 9, 2023
Merged

Damping bcs #351

merged 4 commits into from
Feb 9, 2023

Conversation

danieljprice
Copy link
Owner

Type of PR:
Bug fix

Description:
couple of small bug fixes, restart with particle injection would fail if particle updates occurred at t=0, because updated particles are tagged as unknown until update_injected_particles is called. The failure gave:

 FATAL ERROR! energies: particle type <= 0

 FATAL ERROR! energies: particle type <= 0

also fixed a floating point exception in accretion energy since accradius1 can be equal to zero if a softened potential is employed

Testing:
Successful ability to restart the code for a simulation with particle re-injection (inject_steadydisc.f90)

Did you run the bots? no

@danieljprice danieljprice merged commit f0bf596 into master Feb 9, 2023
@danieljprice danieljprice deleted the damping-bcs branch February 9, 2023 03:26
s-neilson pushed a commit to s-neilson/phantom that referenced this pull request Mar 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant