Dust growth: mass-weighted interpolations of dust-gas quantities #377
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…now default, option removed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Dust growth: mass-weighted interpolations of dust-gas quantities are now default, option removed
Type of PR:
Modification to existing code
Description:
Option to interpolate dust gas quantities such as gas density or sound speed by mass or mass/density when using dust growth has been removed. Mass weighted interpolations are more accurate than mass/density interpolations.
It was not needed to keep the mass/density weighted interpolation in the code, and thus was removed.
Left: Radial profiles of sound velocity interpolation for two different methods (red: mass weighted, blue: mass/density weighted). Right: Interpolation of the sound speed on each dust particle for two different methods. The profiles in the left panel are calculated from the distributions in the right panel by averaging the values per bin of radius.
Testing:
wbymassoption has been removed from force.f90, growth.f90 and test_dustgrowth.f90.I ran the phantom test suite + test_dustgrowth. I tested the
growingdiscsetup with all the options.Did you run the bots? no