Wind bug fixes #392
Merged
Wind bug fixes #392
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… to the calculation of the total Eddington factor
There was a problem hiding this comment.
looks good. Please can you explain why the mass loss accounting from the sink particle was removed?
Also what was the reason for #391 as to why the Mdot was off by a factor of two?
…mpose wind_injection_radius=Reff in ray_tracer + fix Makefiles
…ag to run specific bots
|
Hi Lionel & Mats, I fixed the build failure. I cannot update this pull request directly, so instead I submitted the changes to your fork via a pull request, which when accepted should automatically update (and fix) this one. The only change is to get rid of the compiler warnings, plus I merged the latest code and fixed the conflict in the AUTHORS file. Cheers, Daniel |
|
Hi Daniel
I just merged lsiess-master with my master branch and pushed it.
Thanks for your help with the compiler option!
Cheers
Lionel
…On Wed, 05 Apr 2023 18:22:31 -0700 Daniel Price ***@***.***> wrote:
Hi Lionel & Mats,
I fixed the build failure. I cannot update this pull request directly, so instead I
submitted the changes to your fork via a pull request, which when accepted should
automatically update (and fix) this one. The only change is to get rid of the compiler
warnings, plus I merged the latest code and fixed the conflict in the AUTHORS file.
Cheers,
Daniel
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of PR:
Bug fixes
Description:
Fix bugs, clean code and improve comments
Testing:
ran simulations with all ray-tracing options in both single and binary star systems
Did you run the bots? yes