Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(set_star) shifted all the work in setup_star into set_star routine #407

Merged
merged 2 commits into from
Apr 28, 2023

Conversation

danieljprice
Copy link
Owner

Type of PR:
cleanup / structural changes to set_star

Description:

The aim of this change is to be able to perform all the functionality of setup_star from any setup routine in phantom. This is with the intention of making several "two-step" setup-and-moddump procedures into a single, streamlined procedure. For example, the TDE setup could add a star, relax the star and place it into orbit without needing the moddump procedure. Similarly, this change allows implementation a binary, triple or hierarchical star setup with multiple stars read from MESA tables.

The changes to the code at the moment are purely structural, there is no change in functionality:

  • added new set_star routine/module that does all the steps in setup_star
  • set_star provides routines to read/write/ask for all the options needed to setup and relax a single stellar model
  • teased apart the options that would be per-star from the equation of state options that are per-setup

Testing:
Testing on AGB stellar model with sink particle core, ensuring setup procedure proceeds as previously

Did you run the bots? no

Did you update relevant documentation in the docs directory? no

…split star options from eos options in .setup file
Copy link
Collaborator

@themikelau themikelau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks okay.

@danieljprice danieljprice merged commit b3f892b into master Apr 28, 2023
@danieljprice danieljprice deleted the set_star branch April 28, 2023 06:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants