(set_star) shifted all the work in setup_star into set_star routine #407
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of PR:
cleanup / structural changes to set_star
Description:
The aim of this change is to be able to perform all the functionality of setup_star from any setup routine in phantom. This is with the intention of making several "two-step" setup-and-moddump procedures into a single, streamlined procedure. For example, the TDE setup could add a star, relax the star and place it into orbit without needing the moddump procedure. Similarly, this change allows implementation a binary, triple or hierarchical star setup with multiple stars read from MESA tables.
The changes to the code at the moment are purely structural, there is no change in functionality:
Testing:
Testing on AGB stellar model with sink particle core, ensuring setup procedure proceeds as previously
Did you run the bots? no
Did you update relevant documentation in the docs directory? no