Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

setup multiple stars #411

Merged
merged 21 commits into from
May 5, 2023
Merged

setup multiple stars #411

merged 21 commits into from
May 5, 2023

Conversation

danieljprice
Copy link
Owner

@danieljprice danieljprice commented May 4, 2023

Type of PR:
new setup

Description:

  • In setup_binary, can make both stars either a sink particle or a gaseous sphere from a stellar profile
  • code calls set_star multiple times to add stars
  • second and subsequent stars automatically determine the particle number given the resolution in the first star
  • same code called from setup_star
  • relaxation works to set-and-relax one star after the other
  • added new set_units module to simplify read/write of units information from .setup files

Caveats:

  • during the relaxation procedure, dump files generated for the second star are currently artificially large (contains the first star but with masked particles)

Testing:
can successfully setup-and-relax two stars and place them into orbit around each other. Tested with polytopes and MESA profiles, would be good to add automated test for this

Did you run the bots? yes

Did you update relevant documentation in the docs directory? yes

@danieljprice danieljprice merged commit a7381be into master May 5, 2023
@danieljprice danieljprice deleted the set_star branch May 5, 2023 20:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant