Compute total enclosed mass in self-gravitating disc initial conditions #427
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dust enclosed mass to initialize correctly the dust velocity
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of PR:
Bug fix
Description:
There is a bug when setting up dust in self-gravitating discs where the enclosed mass is not computed correctly.
The new code computes enclosed dust and gas mass to take into account the disc self gravity in the velocity initialisation
Testing:
make SETUP=dustyisosgdisc setup
./phantomsetup disc
check that velocities of gas and dust particles are the same
Did you run the bots? no
Did you update relevant documentation in the docs directory? no