(grtde) BUG FIX with units in GR tidal disruption event setup #432
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of PR:
Bug fix (thanks to Martina Toscani for reporting)
Description:
Mass and radius of star in .setup file for SETUP=grtde was messed up because of incorrect unit conversions
Testing:
this works now without getting very small values of Mstar and Rstar in the .setup file. The issue was that for the GR setup the central mass needs to be 1 in code units, but we take mhole as an input parameter, so the units need to be set immediately AFTER mhole is read, but BEFORE the star options are read from the .setup file.
Did you run the bots? no
Did you update relevant documentation in the docs directory? no