Remove leftover ifdef statements to fix stirring bug #449
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
thanks Terry, we really should have a test that picks up this kind of thing... |
danieljprice
added a commit
that referenced
this pull request
Jul 6, 2023
danieljprice
added a commit
that referenced
this pull request
Jul 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of PR:
Bug fix
Description:
Turbulent stirring had the ifdef STIR_FROM_FILE removed in commit 7c86f4e. One set of ifdef statements were missed. This would cause the turbulent stirring to try to not stir from file. Now all STIR_FROM_FILE ifdef statements are removed, instead using the logical parameter.
Testing:
Before and after test on SETUP=turb. Previously would error the first time the code tried to force.
Did you run the bots? N/A
Did you update relevant documentation in the docs directory? N/A