-
Notifications
You must be signed in to change notification settings - Fork 246
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update to analysis_common_envelope #591
Conversation
…n energy calculation
The test suite caught a bug with the cons2prim test. There was an issue because I have lumped some changes to entropy calculation in this pull request. Namely, I have ensured that any temperature solving uses the gas constant, |
See comment on splash PR, would be better to use .cols file which is an existing splash feature |
Also the cons2prim stuff should be pretty well unit tested so happy to approve that |
It is time to update this analysis module.
Changes to analysis_common_envelope:
Changes to other parts of Phantom:
entropy
ineos
module: Add option to specify radiation temperature directly, which is useful if using radiation and Trad is stored.radiation_utils
: RedefineradE_from_Trad
(output is energy per unit volume) toradxi_from_Trad
(output is energy per unit mass), the latter being more useful. Likewise, the inverse function is also changed fromTrad_from_radE
toTrad_from_rhoxi
. The rest of the code has been adjusted to be consistent with these new definitions.eos_idealplusrad
: Add functions to calculate gas energy and radiation energy separately.