Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correct spelling errors in tree. Seen using Debian's 'lintian' package. #88

Merged
merged 1 commit into from
Sep 15, 2024

Conversation

kathenas
Copy link
Contributor

Hi,

My name is Phil Wyett, I am the new primary maintainer of splash in Debian under the umbrella of the Debian Astronomy Team.

A small initial merge request to assist this upstream project.

Correct spelling errors in tree. Seen using Debian's 'lintian' package.

I hope we will collaborate in the future to make sure the best splash is delivered to users.

Regards

Phil

@danieljprice
Copy link
Owner

Hi Phil,

Thanks for the PR. What would be great here is to hook up the Debian repo to the splash release workflow (in .github/workflows/). For example this workflow automatically updates the homebrew package when I push a release and it would be great for the Ubuntu package to do the same.

A wider problem is a lack of unit /integration testing in splash. Tests of format readers would be an easy one to implement, I have some ideas here for a test harness but it slips down the priority list (and a bit tricky because to run the tests the actions would need to download a bunch of files). In practice my testing is "eat your own dogfood" in that we use bleeding edge splash regularly in the group so tend to spot problems quickly.

Would welcome any suggestions/help here.

Best wishes,

Daniel

@danieljprice danieljprice merged commit 141fe08 into danieljprice:master Sep 15, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants