Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update apkdiff.py #7

Merged
merged 1 commit into from
Aug 23, 2021
Merged

Conversation

soulee-dev
Copy link
Contributor

Problem

As mentioned in Issue #4 (comment)

Some of OS has problem with line

call(["apktool", "d", "--no-debug-info", "-o", dir, file], stdout=open(os.devnull, 'w'), stderr=STDOUT)

Suggest

 call(["apktool", "d", "--no-debug-info", "-o", dir, file], stdout=open(os.devnull, 'w'), stderr=STDOUT) 

Shell should be true for OS compatibility.
If the shell is true, command will be executed through the shell according to Python Docs

Shell should be true for OS compatibility.
@daniellockyer daniellockyer merged commit ece082b into daniellockyer:master Aug 23, 2021
@Sparrrgh
Copy link

This change broke the tool both in Windows and Ubuntu. Without shell=True it works fine

@TheDauntless TheDauntless mentioned this pull request Apr 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants