Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: prepare for laravel 11 #61

Merged
merged 4 commits into from
Feb 24, 2024
Merged

chore: prepare for laravel 11 #61

merged 4 commits into from
Feb 24, 2024

Conversation

joostdebruijn
Copy link
Contributor

Prepares for the release of Laravel 11 within a few weeks.

@joostdebruijn
Copy link
Contributor Author

@danielme85 It's now running well with Laravel 10, however for Laravel 11 the dependency mongodb/laravel-mongodb should be updated to work with Laravel 11. Will have a look at that later.

Copy link

codecov bot commented Feb 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 93.05%. Comparing base (331fa33) to head (9d45eb1).
Report is 12 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff              @@
##               main      #61      +/-   ##
============================================
- Coverage     96.73%   93.05%   -3.69%     
+ Complexity      118      111       -7     
============================================
  Files            13       13              
  Lines           276      288      +12     
============================================
+ Hits            267      268       +1     
- Misses            9       20      +11     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@danielme85
Copy link
Owner

@danielme85 It's now running well with Laravel 10, however for Laravel 11 the dependency mongodb/laravel-mongodb should be updated to work with Laravel 11. Will have a look at that later.

thanks @joostdebruijn 👍 , we might just have to wait for laravel-mongodb to update their package requirements.

@danielme85
Copy link
Owner

I think I'll separate out all mongodb testing and skip them for L11 then make an alpha release or something ¯_(ツ)_/¯

Silly to be held back if you don't use mongodb at all.

@joostdebruijn
Copy link
Contributor Author

@danielme85 Yesterday they merged this one: mongodb/laravel-mongodb#2735, so they have L11 support on their dev now.

@danielme85 danielme85 merged commit 3e2a1f5 into danielme85:main Feb 24, 2024
5 of 6 checks passed
@danielme85
Copy link
Owner

Aright all good, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants