Can't add SRV records anymore

[leshik]

Hi,

I'm unable to add SRV type records with this tool anymore, e.g. something like this:

cfcli -d example.org -t SRV add _test._tcp.example.org 0 0 1234 server.example.org

I'm sure it was working several months ago as I have built this command into my scripts that were working at a time. Apparently CF changed something that breaks the tool. Tried with priority option too but no luck.

[leshik]

I investigated further using curl and CF API documentation & examples. Previously, it was working like this (and that's how the documentation tells us to add DNS records):

curl -X POST "https://api.cloudflare.com/client/v4/zones/023e105f4ecef8ad9ca31a8372d0c353/dns_records" \
     -H "X-Auth-Email: user@example.com" \
     -H "X-Auth-Key: c2547eb745079dac9320b638f5e225cf483cc5cfdda41" \
     -H "Content-Type: application/json" \
     --data '{"type":"SRV","name":"_test._tcp.example.org","content":"0 0 1234 server.example.org"}'

This is not the case anymore. The API will return the error:

{
  "success": false,
  "errors": [
    {
      "code": 1004,
      "message": "DNS Validation Error",
      "error_chain": [
        {
          "code": 9101,
          "message": "service is a required data field."
        }
      ]
    }
  ],
  "messages": [],
  "result": null
}

Seems now there should be an additional data field inside the JSON, i.e.:

curl -X POST "https://api.cloudflare.com/client/v4/zones/023e105f4ecef8ad9ca31a8372d0c353/dns_records" \
     -H "X-Auth-Email: user@example.com" \
     -H "X-Auth-Key: c2547eb745079dac9320b638f5e225cf483cc5cfdda41" \
     -H "Content-Type: application/json" \
     --data '{"type":"SRV","name":"_test._tcp.example.org","content":"0 0 1234 server.example.org","data":{"priority":0,"weight":0,"port":1234,"target":"server.example.org","service":"_test","proto":"_tcp","name":"example.org"}}'

This works well, though not documented. Seems this should be changed in cfcli tool too.

[leshik]

This JSON might look a bit redundant, I tested and it seems we can avoid duplication by removing name and content fields:

{
  "type": "SRV",
  "data": {
    "service": "_test",
    "proto": "_tcp",
    "name": "example.org",
    "priority": 0,
    "weight": 0,
    "port": 1234,
    "target": "server.example.org"
  }
}

It works ok too.

[leshik]

Turned out, priority, weight and port can't be of type String anymore. I've made PR #47 that fixes it.

[leshik]

I've also fixed priority parsing, it should be at index 0. In master it always equals to weight.