Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix external terminal launching on mac(darwin) #54

Merged
merged 1 commit into from
Apr 12, 2019
Merged

fix external terminal launching on mac(darwin) #54

merged 1 commit into from
Apr 12, 2019

Conversation

LazyRen
Copy link
Contributor

@LazyRen LazyRen commented Apr 12, 2019

Hi, First of all, thanks for such a great extension.
As #28 mentioned, original extension does not allow me to use external terminal for the mac Terminal.

I had some osascript that I previously used for Sublime Text, so I gave it a shot for myself.

It works fine for my installed extension even tho it is not the best solution.(using delay command and such..)

Hope this helps!

p.s.
For the extension I installed, it uses term ${file.$directory},
but forked one uses ${file.directory}. I did changed in this way, but not sure this is the right way.

@danielpinto8zz6 danielpinto8zz6 merged commit 152c355 into danielpinto8zz6:master Apr 12, 2019
@danielpinto8zz6
Copy link
Owner

hi,
thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants