fix external terminal launching on mac(darwin) #54
+2
−2
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi, First of all, thanks for such a great extension.
As #28 mentioned, original extension does not allow me to use external terminal for the mac Terminal.
I had some osascript that I previously used for Sublime Text, so I gave it a shot for myself.
It works fine for my installed extension even tho it is not the best solution.(using delay command and such..)
Hope this helps!
p.s.
For the extension I installed, it uses term
${file.$directory}
,but forked one uses
${file.directory}
. I did changed in this way, but not sure this is the right way.