Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: add types field for node16/nodenext module resolution #462

Merged
merged 2 commits into from
May 1, 2023
Merged

fix: add types field for node16/nodenext module resolution #462

merged 2 commits into from
May 1, 2023

Conversation

LiamMartens
Copy link
Collaborator

…resolution mode

@LiamMartens
Copy link
Collaborator Author

the typings fail in projects which use the node16 module resolution strategy without an explicit types export

@LiamMartens LiamMartens requested a review from danielroe May 1, 2023 01:21
danielroe
danielroe reviewed May 1, 2023
View reviewed changes
package.json Outdated Show resolved Hide resolved
@danielroe danielroe changed the title fix(package.json): fixes ts declaration resotion for node16/nodenext … fix: add types field for node16/nodenext module resolution May 1, 2023
@danielroe danielroe merged commit 11900de into main May 1, 2023
@danielroe danielroe deleted the fix/node-module-resolution branch May 1, 2023 09:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danielroe danielroe danielroe left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@LiamMartens @danielroe