Skip to content

Commit

Permalink
feat(file): alternate file implementation (#283)
Browse files Browse the repository at this point in the history
* alternate file implementation

* SocialSharing: Add recommended `shareWithOptions` method

* Revert "SocialSharing: Add recommended `shareWithOptions` method"

* refactor(file): tslint & remove window declaration

* export all from file

* remove the cordova export and declaration
  • Loading branch information
ihadeed authored Aug 11, 2016
1 parent 43e8a6d commit 6ed32ef
Show file tree
Hide file tree
Showing 2 changed files with 781 additions and 410 deletions.
8 changes: 8 additions & 0 deletions src/index.ts
Original file line number Diff line number Diff line change
Expand Up @@ -93,7 +93,11 @@ export * from './plugins/datepicker';
export * from './plugins/device';
export * from './plugins/devicemotion';
export * from './plugins/deviceorientation';
<<<<<<< HEAD
export * from './plugins/file';
=======
export * from './plugins/facebook';
>>>>>>> master
export * from './plugins/filetransfer';
export * from './plugins/geolocation';
export * from './plugins/googlemaps';
Expand Down Expand Up @@ -137,7 +141,11 @@ export {
Dialogs,
Diagnostic,
EmailComposer,
<<<<<<< HEAD
Facebook,
=======
File,
>>>>>>> master
Flashlight,
Globalization,
GooglePlus,
Expand Down
Loading

1 comment on commit 6ed32ef

@Barryrowe
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Am I missing something, or does this clobber the only ability to quickly get a reference to a directory?

Before this update we could use checkDir() to get a handle on the directory in question. Now we just get a boolean, and there's no public getDirectory() to replace this functionality.

Please sign in to comment.