Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(File): typing where FileError can be thrown #1086

Merged
merged 1 commit into from
Mar 2, 2017
Merged

fix(File): typing where FileError can be thrown #1086

merged 1 commit into from
Mar 2, 2017

Commits on Feb 17, 2017

  1. Fix return typing where FileError is possible 

    Promises that reject with a `FileError` are not of the type `Promise<T|FileError>`, but `Promise<T>`.

The previous declarations of `Promise<T|FileError>` would break typing further down the chain where you are trying to use the value that the typing says could be `T|FileError` but in reality could only be `T`.
    @vegardlarsen
    vegardlarsen committed Feb 17, 2017
    Configuration menu
    Copy the full SHA
    6dcdd41 View commit details
    Browse the repository at this point in the history