Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(plugin): fix #1001, screen-orientation 1.4.2 lockOrientation not return promise. #1116

Merged
merged 1 commit into from
Mar 2, 2017
Merged

fix(plugin): fix #1001, screen-orientation 1.4.2 lockOrientation not return promise. #1116

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 3 additions & 4 deletions src/plugins/screen-orientation.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,11 +48,10 @@ export class ScreenOrientation {
/**
* Lock the orientation to the passed value.
* See below for accepted values
* @param orientation {string} The orientation which should be locked. Accepted values see table below.
* @returns {Promise<any>} returns a promise that resolves when the screen orientation is locked, and rejects when an error occurs.
* @param orientation {string} The orientation which should be locked. Accepted values see table above.
*/
@Cordova({ otherPromise: true })
static lockOrientation(orientation: string): Promise<string> { return; }
@Cordova({ sync: true })
static lockOrientation(orientation: string): void { }

/**
* Unlock and allow all orientations.
Expand Down