Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(google-multiple-maps): change for google-map plugin v2-beta #1424

Closed
wants to merge 1 commit into from
Closed

Conversation

kostap13
Copy link
Contributor

@ihadeed
Copy link
Collaborator

ihadeed commented Apr 27, 2017

We've had this PR for awhile: #1166

@battika
Copy link

battika commented Jun 1, 2017

Guys, according to the plugin author some recent events are not included in the PR. Can you please have a look into the event list at the following link:

https://github.com/mapsplugin/cordova-plugin-googlemaps-doc/blob/master/v2.0.0/ReleaseNotes/v2.0-beta2/README.md

Copy link
Contributor

@wf9a5m75 wf9a5m75 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for creating this PR. You saved my time.

I noticed these things:

  • The showDialog() / closeDialog() methods are not provided in the plugin v2.

  • KML overlay is not ready yet. Please don't implement it (yet).

  • TileOverlayOptions does not use the tileUrlFormat anymore. Use the getTile callback.

  • You missed the BaseArray class. Actually it's the one of the key class of the plugin v2.

  • the geocoder returns the BaseArray class instance if you pass multiple location requests at once.

  • the polygon.getPoints() / polygon.getHoles() / the polyline.getPoints () are also returns the BaseArray class instance instead of Array.

  • You need to specify the #multiple_maps branch to install the v2 so far.

  • map.getVisibleRegion() returns the value as {sync: true}, no more callback.

  • map.setBackgroundColor() and map.getLicenceInfo() methods are moved to the Environment class.

  • map.setDebug() is not implemented.

  • some methods such as map.animateCameraZoonIn() are missing.

  • HTMLinfoWindow class is also missing.


That's it I noticed so far. Thank you for your contribution.

@ihadeed
Copy link
Collaborator

ihadeed commented Jun 1, 2017

@battika this is why I suggested in other comments to wait until v2 is stable before updating our wrapper.

We can't predict what their final API will look like, and it will be time consuming to try and keep up with them.

@wf9a5m75
Copy link
Contributor

wf9a5m75 commented Jun 1, 2017

Hi, @ihadeed This is Masashi the author of cordova-googlemaps-plugin.

One of the reason of beta is that I have been waiting the ionic wrapper for the v2 since I'm not familiar with ionic. (I noticed this PR today actually)

Another reason is I have been developing the marker clustering feature recently.
After that, I will merge the multiple_maps branch to the master branch (become the stable version).

Technically, the code is stable.
I might add or modify a few changes, but I wont change the api significantly.

@ihadeed
Copy link
Collaborator

ihadeed commented Jun 1, 2017

Thanks for the update @wf9a5m75

@jayeshanandani
Copy link

Can we get in this, please? Not able to use the latest version of Google maps with current ionic native code.

@fzamperin
Copy link

Would be nice to have latest version of Google Maps with ionic native code, need support for HTMLinfoWindow class.

@ihadeed
Copy link
Collaborator

ihadeed commented Jul 4, 2017

Closing this in favour of #1759

@ihadeed ihadeed closed this Jul 4, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants