Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(document-viewer): fix example #1568

Merged
merged 3 commits into from
May 16, 2017
Merged

refactor(document-viewer): fix example #1568

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
486b0a2
refactor(document-viewer): fix example
danielsogl May 16, 2017
346d72c
Update index.ts
danielsogl May 16, 2017
13ca68a
Update index.ts
danielsogl May 16, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 4 additions & 3 deletions src/@ionic-native/plugins/document-viewer/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,10 +42,11 @@ export interface DocumentViewerOptions {
* constructor(private document: DocumentViewer) { }
*
* ...
* const options = {
* const options: DocumentViewerOptions = {
* title: 'My PDF'
* }
* this.document.view('assets/myFile.pdf', 'application/pdf', options)
*
* this.document.viewDocument('assets/myFile.pdf', 'application/pdf', options)
*
* ```
*
Expand Down Expand Up @@ -82,7 +83,7 @@ export class DocumentViewer extends IonicNativePlugin {
* @param [onError] {Function}
*/
@Cordova({ sync: true })
canViewDocument(url: string, contentType: string, options: Array<DocumentViewerOptions>, onPossible?: Function, onMissingApp?: Function, onImpossible?: Function, onError?: Function): void { }
canViewDocument(url: string, contentType: string, options: DocumentViewerOptions, onPossible?: Function, onMissingApp?: Function, onImpossible?: Function, onError?: Function): void { }
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The docs above need to be updated as well to reflect this change


/**
* Opens the file
Expand Down