feat(headercolor): add HeaderColor plugin #821
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ihadeed
requested changes
Nov 29, 2016
| * @param {Object} Optional callbacks | ||
| */ | ||
| @Cordova() | ||
| static tint(color: string, callbacks?: {success?: Function, failure?: Function}): void { } |
There was a problem hiding this comment.
This should return a Promise.
The decorator should include the following options:
@Cordova({
callbackStyle: 'object',
successName: 'success',
errorName: 'failure'
})
Then finally remove the callbacks parameter.
ihadeed
approved these changes
Dec 1, 2016
ihadeed
requested changes
Dec 1, 2016
| successName: 'success', | ||
| errorName: 'failure' | ||
| }) | ||
| static tint(color: string): Promise<any> { } |
There was a problem hiding this comment.
Need to add return; between the curly brackets to avoid TS Errors.
| /** | ||
| * Set a color to the task header | ||
| * @param color {string} The color | ||
| */ |
There was a problem hiding this comment.
add @returns {Promise<any>}
ihadeed
approved these changes
Dec 1, 2016
mebibou
reviewed
Dec 14, 2016
| @Plugin({ | ||
| name: 'HeaderColor', | ||
| plugin: 'cordova-plugin-headercolor', | ||
| pluginRef: 'headercolor', |
There was a problem hiding this comment.
Shouldn't this be pluginRef: 'headerColor', ?
There was a problem hiding this comment.
just had a look
It should be plugins.headerColor
ihadeed
requested changes
Dec 15, 2016
| @Plugin({ | ||
| name: 'HeaderColor', | ||
| plugin: 'cordova-plugin-headercolor', | ||
| pluginRef: 'headercolor', |
There was a problem hiding this comment.
just had a look
It should be plugins.headerColor
added 2 commits
January 18, 2017 18:58
|
@John-Luke changes look good, please see #821 (comment) |
ihadeed
approved these changes
Jan 19, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #760