-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(ionicnative): add instance wrapper #97
Conversation
Nice! I'd maybe remove the console logs and have CordovaInstance call wrapInstance directly so you can get rid of |
@ihadeed Where are you at on this one? I am looking to add keychain and will need to use something like this. Should I use the instance_wrapper branch or are you pretty close to pushing these changes to master? |
Hey Keith, If I remember correctly, the concept I had in mind is already implemented I'm using the instance_wrapper branch to develop the wrapper and some of I would suggest to develop on that branch so we can alter the instance @ihadeed https://github.com/ihadeed Where are you at on this one? I am — Reply to this email directly or view it on GitHub |
…o instance-wrapper
closes #86
closes #79
@tlancina Came up with this over night, it worked with the SQLite plugin. Haven't tested with other plugins. Let me know what you think.
Example of implementation: https://github.com/driftyco/ionic-native/blob/instance-wrapper/src/plugins/sqlite.ts