Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't omit middle components in long-form times #2962

Closed
macdjord opened this issue Feb 12, 2022 · 0 comments · Fixed by #4132
Closed

Don't omit middle components in long-form times #2962

macdjord opened this issue Feb 12, 2022 · 0 comments · Fixed by #4132

Comments

@macdjord
Copy link

When the GUI displays a duration, e.g. the run-time of a script on the active scripts tab, or the time since installing augs on the stats tab, it formats it with numeric values and written unit names, e.g. "6 hours 3 minutes 2 seconds".

Currently, any time element which is 0 is omitted entirely, e.g. "6 hours 12 seconds" instead of "6 hours 0 minutes 12 seconds". However, it makes such times less readable - it is easy to mistake "6 hours 12 seconds" for "6 hours 12 minutes" at a glance, because we expect the unit after 'hour' to be 'minute'. Similarly, if you have multiple dates with the same number of displayed components but different units, its easy to miss that difference in units, e.g. if you have "6 hours 12 minutes" followed by "6 minutes 40 seconds", it's easy to mistake that as two very similar times rather than two times which differ by an order of magnitude.

I propose that this be changed, so that only leading components are omitted when 0.

Version: a3c599e

borisflagell added a commit to borisflagell/bitburner that referenced this issue May 21, 2022
…Time Elapsed String

Fix danielyxie#2962 Add a setting to display middle time unit in Time Elapsed String
hydroflame added a commit that referenced this issue Sep 23, 2022
UI: FIX #2962 Add a setting to display middle time unit in Time Elapsed String
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants