Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RunningScript is killed based on whether args match, fails if player mutates args. (v2.0) #3962

Closed
3 tasks done
Snarling opened this issue Aug 7, 2022 · 0 comments · Fixed by #3964
Closed
3 tasks done

Comments

@Snarling
Copy link
Contributor

Snarling commented Aug 7, 2022

The above results in the ability to have ghost scripts that continue using their ram even after they are killed, and also results in a possible exploit where a player can ||have two scripts switch args, and kill the one with fewer threads to remove the ram cost from the one with more threads||.

  • Minimal scripts to reproduce the issue
export let main=ns=>ns.args.push(1);

Script above will not show up on the Active Scripts page but will show up using ps and will continue to consume ram.

  • Steps to reproduce
    Run the above script

  • Version of the game: Bitburner v2.0.0 (8e859d8)

hydroflame added a commit that referenced this issue Aug 9, 2022
SCRIPTS: FIX #3962 The correct script will be closed even if the player modifies args (v2.0)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant