-
-
Notifications
You must be signed in to change notification settings - Fork 164
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Merge branch 'master' into maint-3.9
- Loading branch information
Showing
40 changed files
with
2,417 additions
and
79 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,16 @@ | ||
name: build-ubuntu | ||
|
||
# Controls when the action will run. | ||
on: | ||
push: | ||
pull_request: | ||
workflow_dispatch: | ||
|
||
jobs: | ||
build-ubuntu: | ||
runs-on: ubuntu-latest | ||
|
||
steps: | ||
# Checks-out your repository under $GITHUB_WORKSPACE, so your job can access it | ||
- uses: actions/checkout@v2 | ||
- uses: daniestevez/gr-satellites-ci-action@v1.2.1 |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,142 @@ | ||
# gr-satellites Code of Conduct | ||
|
||
As a GNU Radio out-of-tree module and a project which is part of the GNU Radio | ||
community understood in a wide sense, gr-satellites follows the same code of | ||
conduct as GNU Radio. This is a copy of the Code of Conduct. It might be out of | ||
date. The latest version can be found [on the gnuradio/gr-governance | ||
repository](https://github.com/gnuradio/gr-governance/blob/main/CODE_OF_CONDUCT.md). | ||
|
||
## Our Pledge | ||
|
||
We as members, contributors, and leaders pledge to make participation in our | ||
community a harassment-free experience for everyone, regardless of age, body | ||
size, visible or invisible disability, ethnicity, sex characteristics, gender | ||
identity and expression, level of experience, education, socio-economic status, | ||
nationality, personal appearance, race, caste, color, religion, or sexual identity | ||
and orientation. | ||
|
||
We pledge to act and interact in ways that contribute to an open, welcoming, | ||
diverse, inclusive, and healthy community. | ||
|
||
## Our Standards | ||
|
||
Examples of behavior that contributes to a positive environment for our | ||
community include: | ||
|
||
* Demonstrating empathy and kindness toward other people | ||
* Being respectful of differing opinions, viewpoints, and experiences | ||
* Giving and gracefully accepting constructive feedback | ||
* Accepting responsibility and apologizing to those affected by our mistakes, | ||
and learning from the experience | ||
* Focusing on what is best not just for us as individuals, but for the | ||
overall community | ||
|
||
Examples of unacceptable behavior include: | ||
|
||
* The use of sexualized language or imagery, and sexual attention or | ||
advances of any kind | ||
* Trolling, insulting or derogatory comments, and personal or political attacks | ||
* Public or private harassment | ||
* Publishing others' private information, such as a physical or email | ||
address, without their explicit permission | ||
* Other conduct which could reasonably be considered inappropriate in a | ||
professional setting | ||
|
||
## Enforcement Responsibilities | ||
|
||
Community leaders are responsible for clarifying and enforcing our standards of | ||
acceptable behavior and will take appropriate and fair corrective action in | ||
response to any behavior that they deem inappropriate, threatening, offensive, | ||
or harmful. | ||
|
||
Community leaders have the right and responsibility to remove, edit, or reject | ||
comments, commits, code, wiki edits, issues, and other contributions that are | ||
not aligned to this Code of Conduct, and will communicate reasons for moderation | ||
decisions when appropriate. | ||
|
||
## Scope | ||
|
||
This Code of Conduct applies within all community spaces, and also applies when | ||
an individual is officially representing the community in public spaces. | ||
Examples of representing our community include using an official e-mail address, | ||
posting via an official social media account, or acting as an appointed | ||
representative at an online or offline event. | ||
|
||
## Enforcement | ||
|
||
Instances of abusive, harassing, or otherwise unacceptable behavior may be | ||
reported by contacting Daniel Estevez at daniel@destevez.net (who is the | ||
gr-satellite main developer) or the GNU Radio project Code of Conduct team at | ||
conduct@gnuradio.org (only if applicable; gr-satellites is related to the GNU | ||
Radio project and community, but formally not part of the GNU Radio project and | ||
governance). All complaints will be reviewed and investigated promptly and | ||
fairly. | ||
|
||
All community leaders are obligated to respect the privacy and security of the | ||
reporter of any incident. | ||
|
||
## Enforcement Guidelines | ||
|
||
Community leaders will follow these Community Impact Guidelines in determining | ||
the consequences for any action they deem in violation of this Code of Conduct: | ||
|
||
### 1. Correction | ||
|
||
**Community Impact**: Use of inappropriate language or other behavior deemed | ||
unprofessional or unwelcome in the community. | ||
|
||
**Consequence**: A private, written warning from community leaders, providing | ||
clarity around the nature of the violation and an explanation of why the | ||
behavior was inappropriate. A public apology may be requested. | ||
|
||
### 2. Warning | ||
|
||
**Community Impact**: A violation through a single incident or series | ||
of actions. | ||
|
||
**Consequence**: A warning with consequences for continued behavior. No | ||
interaction with the people involved, including unsolicited interaction with | ||
those enforcing the Code of Conduct, for a specified period of time. This | ||
includes avoiding interactions in community spaces as well as external channels | ||
like social media. Violating these terms may lead to a temporary or | ||
permanent ban. | ||
|
||
### 3. Temporary Ban | ||
|
||
**Community Impact**: A serious violation of community standards, including | ||
sustained inappropriate behavior. | ||
|
||
**Consequence**: A temporary ban from any sort of interaction or public | ||
communication with the community for a specified period of time. No public or | ||
private interaction with the people involved, including unsolicited interaction | ||
with those enforcing the Code of Conduct, is allowed during this period. | ||
Violating these terms may lead to a permanent ban. | ||
|
||
### 4. Permanent Ban | ||
|
||
**Community Impact**: Demonstrating a pattern of violation of community | ||
standards, including sustained inappropriate behavior, harassment of an | ||
individual, or aggression toward or disparagement of classes of individuals. | ||
|
||
**Consequence**: A permanent ban from any sort of public interaction within | ||
the community. | ||
|
||
## Attribution | ||
|
||
This Code of Conduct is adapted from the [Contributor Covenant][homepage], | ||
version 2.0, available at | ||
[https://www.contributor-covenant.org/version/2/0/code_of_conduct.html][v2.0]. | ||
|
||
Community Impact Guidelines were inspired by | ||
[Mozilla's code of conduct enforcement ladder][Mozilla CoC]. | ||
|
||
For answers to common questions about this code of conduct, see the FAQ at | ||
[https://www.contributor-covenant.org/faq][FAQ]. Translations are available | ||
at [https://www.contributor-covenant.org/translations][translations]. | ||
|
||
[homepage]: https://www.contributor-covenant.org | ||
[v2.0]: https://www.contributor-covenant.org/version/2/0/code_of_conduct.html | ||
[Mozilla CoC]: https://github.com/mozilla/diversity | ||
[FAQ]: https://www.contributor-covenant.org/faq | ||
[translations]: https://www.contributor-covenant.org/translations | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,70 @@ | ||
# Contributing to gr-satellites | ||
|
||
These guidelines are based on the [contributing guidelines for GNU | ||
Radio](https://github.com/gnuradio/gnuradio/blob/master/CONTRIBUTING.md). Since | ||
gr-satellites is a GNU Radio out-of-tree module, we follow the same guidelines | ||
for consistency wherever it makes sense: coding style, code of conduct, etc. | ||
|
||
## Coding Guidelines | ||
|
||
gr-satellites follows the same coding guidelines as GNU Radio. These are | ||
described in [GREP1][grep1]. | ||
|
||
For C++, clang-format is used. Formatting is checked in the CI pipeline and | ||
can also be checked locally with the `tools/clang_format.py` helper script. | ||
|
||
For Python, we follow PEP8. In contrast to GNU Radio, which doesn't use a Python | ||
formatting checker, since a large amount of the gr-satellites code base is | ||
Python, we use pycodestyle to check PEP8 formatting. This is part of the | ||
CI pipeline and can be checked locally by running pycodestyle. Note that there | ||
are some [folders that are excluded] | ||
(https://github.com/daniestevez/gr-satellites-pycodestyle-action/blob/master/Dockerfile) | ||
from pycodestyle checking. | ||
|
||
## Python or C++? | ||
|
||
While GNU Radio has most of its code base written in C++, gr-satellites has the | ||
majority of its code base written in Python. This allows for a faster | ||
development, and performance is often not so critical, since small satellites | ||
typically transmit using low data rates. In particular, telemetry parsing is | ||
always written in Python using [construct](https://construct.readthedocs.io/). | ||
|
||
However, some kinds of blocks are equally simple to implement in C++ or in | ||
Python, so C++ should be preferred for those. | ||
|
||
## Git commit messages are very important | ||
|
||
The same guidelines as for GNU Radio apply regarding commit messages: | ||
- Keep the lines below 72 characters | ||
- Avoid empty git commit messages | ||
- The git commit message explains the change, the code only explains the current | ||
state | ||
|
||
## Include Unit Tests | ||
|
||
If you have an obvious test, that might speed up the time it takes to convince | ||
reviewers that your code is correct. | ||
|
||
## Adding support for a new satellite | ||
|
||
Adding support for a new satellite can be as easy as writing a [SatYAML | ||
file](https://gr-satellites.readthedocs.io/en/latest/satyaml.html) describing | ||
the satellite if the satellite only uses protocols already supported by | ||
gr-satellites. Since most satellites use a custom telemetry format, a new telemetry | ||
parser should be written using | ||
[construct](https://construct.readthedocs.io/). See the | ||
[python/telemetry](https://github.com/daniestevez/gr-satellites/tree/master/python/telemetry) | ||
folder for some examples, and take note that your new parser should be added | ||
both to `python/telemetry/__index__.py` and to | ||
`python/telemetry/CMakeLists.txt`. | ||
|
||
For satellites using new or ad-hoc custom protocols, some | ||
[components](https://gr-satellites.readthedocs.io/en/latest/components.html) | ||
will need to be written to support them. Most likely, a new deframer will need | ||
to be written. Examples can be found in | ||
[python/components/deframers](https://github.com/daniestevez/gr-satellites/tree/master/python/components/deframers). | ||
|
||
See also the [note to satellite teams] planning to use gr-satellites for their | ||
mission. | ||
|
||
[grep1]: https://github.com/gnuradio/greps/blob/master/grep-0001-coding-guidelines.md |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.