Fix errors when opening the project in Android Studio 3.3 #149
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Update Android Gradle Plugin to 3.3.0 - Update Gradle to 4.10.1 - Change "compile" instances in build.gradle to "implementation" - Remove no longer needed BuildTools variable (build tool version is automatically determined by the Android Gradle Plugin version) - Remove Retrolambda (Java 8 features like lambda methods are fully supported already: https://developer.android.com/studio/write/java8-support) - Update CompileSdk to 28, Support Library version to 28.0.0
|
Hi! I'm the developer of Muzei and was trying to fix #145 and this is blocking my work there. I'd love to fix this, then upgrade wallpaperboard to the newest version of Muzei. |
|
@ianhanniballake Actually the Project is Abandoned. Don't know why, But he is not merging any Pull Requests. Hope he should merge it any day. |
|
Hey @ianhanniballake , Can you Fork this Project and make changes to the library. Like Fixing the #145 . It would be great if you can do this. Then we will be able to use your updated wallpaperboard library via jitpack.io :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #144