Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Package a valid AppImage for Ubuntu 22.04 and Debian 12 #104

Merged
merged 10 commits into from
Dec 17, 2024

Conversation

danirod
Copy link
Owner

@danirod danirod commented Dec 15, 2024

GitHub Actions should come with Linuxbrew.

Since Linuxbrew makes easy to install foreign recipes (such as compiling new versions of dependencies on older versions of an OS, or even downloading bottles), this PR will switch the compilation environment for the AppImage to Homebrew on Ubuntu 22.04.

Ubuntu 22.04 actually packs an older version of glibc than Debian 12, so since Linuxbrew may actually install a version of the dependencies that is compiled against an old version of glibc, this should create an AppImage that actually expects an old version of glibc and thus works on Ubuntu 22.04 and Debian 12.

Apparently this comes preinstalled in the GitHub Actions runners.
@danirod danirod force-pushed the fix/appimage-ubuntu-22 branch from 8f155b0 to 052bc70 Compare December 15, 2024 17:12
Usually this is /usr, but this step is needed to inject different roots
(specifically, Linuxbrew).
At this point, why even try using Linuxdeploy
* It seems that KDE on Wayland requires additional variables to work.
* It also seems that KDE doesn't use an SVG parser as advanced as the
  GTK one, thus the icon looks weird.
Older GNOME versions, like the ones in RHEL 9 or Ubuntu 22.04, still
present the appname in the top bar, but it is being displayed as
AppRun.wrapped. Let's try to directly run usr/bin/cartero and see what
happens.
@danirod danirod force-pushed the fix/appimage-ubuntu-22 branch from f541a90 to b08040e Compare December 17, 2024 01:14
@danirod danirod marked this pull request as ready for review December 17, 2024 01:32
@danirod danirod merged commit fc81208 into trunk Dec 17, 2024
9 checks passed
@danirod danirod deleted the fix/appimage-ubuntu-22 branch December 17, 2024 01:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant