Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix started diff when creating a template #56

Closed
wants to merge 1 commit into from
Closed

Fix started diff when creating a template #56

wants to merge 1 commit into from

Conversation

patsissons
Copy link

@patsissons patsissons commented Dec 13, 2020 •
edited
Loading

Community Note

The started state was being set for templates, even though it doesn't make any sense. This patch simply omits setting the state value if the template flag is set.

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Didn't see an issue for this, but it's pretty easy to repro if you create a template and then try to re-apply.

Release note for CHANGELOG:

BUG FIX: started no longer causes diff issues with templates

@patsissons patsissons marked this pull request as ready for review December 13, 2020 07:39
@patsissons patsissons changed the title fixing started diff when creating a template Fix started diff when creating a template Dec 13, 2020
@danitso-dp danitso-dp mentioned this pull request Jan 2, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@patsissons