Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

support palette-based color #230

Closed
dankamongmen opened this issue Dec 27, 2019 · 2 comments
Closed

support palette-based color #230

dankamongmen opened this issue Dec 27, 2019 · 2 comments
Assignees
@dankamongmen
Labels
documentation Improvements or additions to documentation enhancement New feature or request
Milestone
v1.1.0

Comments

@dankamongmen
Copy link
Owner

It might be desirable to support an 8-bit notcurses-wide palette. This would allow for very fast palette fades and sprite tricks. We could hijack the 16 free bits from the attrword for a fore- and background palette, and 2 of 8 free bits from the channels. Then again, maybe we don't want to blow 75% of our free cell space on this idea.

If we do it, we alloc up 2x256x3 (~1.5KB) for the notcurses struct. the "default color" bits still take ultimate precedence. after that, we use the palette bits if the palette indicator bit is high, and the rgb bits otherwise. setting the rgb bits clears the palette indicator bit. setting the palette bits sets the PIB.
@dankamongmen dankamongmen self-assigned this Dec 27, 2019
@dankamongmen dankamongmen added duplicate This issue or pull request already exists enhancement New feature or request labels Dec 27, 2019
@dankamongmen
Copy link
Owner Author

(if it isn't obvious, the "massive speedup" would come from being able to change colors via o(1) palette swap rather than o(N) walks of the planes, changing their colors).

@dankamongmen dankamongmen removed the duplicate This issue or pull request already exists label Dec 27, 2019
@dankamongmen dankamongmen mentioned this issue Jan 5, 2020
Closed
@dankamongmen dankamongmen added this to the v1.1.0 milestone Jan 14, 2020
dankamongmen added a commit that referenced this issue Jan 15, 2020
@dankamongmen
introduce palette256 #230
d842453
dankamongmen added a commit that referenced this issue Jan 15, 2020
@dankamongmen
more palette support/testing #230
7e5736b
dankamongmen added a commit that referenced this issue Jan 15, 2020
@dankamongmen
send palette updates (initc) #230
04fd953
dankamongmen added a commit that referenced this issue Jan 15, 2020
@dankamongmen
encode palette index into channels/attr #230
fec1bd1
dankamongmen added a commit that referenced this issue Jan 15, 2020
@dankamongmen
palette indexing: set up attributes #230
6b7af2e
@dankamongmen
Copy link
Owner Author

I've added bit definitions and some basic cell_ functionality. I've added the full palette256 functionality. I've updated rasterization to emit the necessary initc commands using an update map. I've updated the various docs and added unit tests.

rendering needs be updated to use this, and then we need a demo (#253).

dankamongmen added a commit that referenced this issue Jan 15, 2020
@dankamongmen
palette: add necessary predicates #230
6a8c5f0
dankamongmen added a commit that referenced this issue Jan 15, 2020
@dankamongmen
introduce palette256 #230
fa01dc2
dankamongmen added a commit that referenced this issue Jan 15, 2020
@dankamongmen
more palette support/testing #230
084579f
dankamongmen added a commit that referenced this issue Jan 15, 2020
@dankamongmen
send palette updates (initc) #230
1113740
dankamongmen added a commit that referenced this issue Jan 15, 2020
@dankamongmen
encode palette index into channels/attr #230
6fec8ad
dankamongmen added a commit that referenced this issue Jan 15, 2020
@dankamongmen
palette indexing: set up attributes #230
4866ffe
dankamongmen added a commit that referenced this issue Jan 15, 2020
@dankamongmen
palette: add necessary predicates #230
17d5c94
dankamongmen added a commit that referenced this issue Jan 17, 2020
@dankamongmen
introduce palette256 #230
51bd4a1
dankamongmen added a commit that referenced this issue Jan 17, 2020
@dankamongmen
more palette support/testing #230
650d8c4
dankamongmen added a commit that referenced this issue Jan 17, 2020
@dankamongmen
send palette updates (initc) #230
660a923
dankamongmen added a commit that referenced this issue Jan 17, 2020
@dankamongmen
encode palette index into channels/attr #230
151f9d2
dankamongmen added a commit that referenced this issue Jan 17, 2020
@dankamongmen
palette indexing: set up attributes #230
6c592a6
dankamongmen added a commit that referenced this issue Jan 17, 2020
@dankamongmen
palette: add necessary predicates #230
d7715f4
@dankamongmen dankamongmen mentioned this issue Jan 17, 2020
Merged
dankamongmen added a commit that referenced this issue Jan 17, 2020
@dankamongmen
introduce palette256 #230
684bcdc
dankamongmen added a commit that referenced this issue Jan 17, 2020
@dankamongmen
more palette support/testing #230
dfcdd10
dankamongmen added a commit that referenced this issue Jan 17, 2020
@dankamongmen
send palette updates (initc) #230
20f4b34
dankamongmen added a commit that referenced this issue Jan 17, 2020
@dankamongmen
encode palette index into channels/attr #230
6365fc0
dankamongmen added a commit that referenced this issue Jan 17, 2020
@dankamongmen
palette indexing: set up attributes #230
0e70304
dankamongmen added a commit that referenced this issue Jan 17, 2020
@dankamongmen
palette: add necessary predicates #230
209d4f4
@dankamongmen dankamongmen added the documentation Improvements or additions to documentation label Jan 17, 2020
dankamongmen added a commit that referenced this issue Jan 17, 2020
@dankamongmen
render+raster palette-index support #230
f5e151e
dankamongmen added a commit that referenced this issue Jan 18, 2020
@dankamongmen
palette_set: update pal256 damage map #230
9f27f62
dankamongmen added a commit that referenced this issue Jan 18, 2020
@dankamongmen
palette_set: update pal256 damage map #230
b2884a6
@dankamongmen dankamongmen mentioned this issue Jan 18, 2020
Closed
dankamongmen added a commit that referenced this issue Jan 18, 2020
@dankamongmen
palette_new: copy existing palette in #230
24aacef
dankamongmen added a commit that referenced this issue Jan 19, 2020
@dankamongmen
render fg palindex #230
52fef03
@dankamongmen dankamongmen mentioned this issue Jan 19, 2020
Merged
dankamongmen added a commit that referenced this issue Jan 19, 2020
@dankamongmen
ruins color cycling demo #253 (#287)
3d612ae 
* palette_set: update pal256 damage map #230
* drone: use newest builders
* palette: send oc on exit for color reset #285
* palette_new: copy existing palette in #230
* Python: use checkRGB everywhere
* more palette unit testing
* add ncplane_set_*_palindex()
* render fg palindex #230
* palette index color is out of 1000
* jungle demo works #253
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dankamongmen dankamongmen

Labels
documentation Improvements or additions to documentation enhancement New feature or request
Projects
None yet
Milestone
v1.1.0
Development

No branches or pull requests
1 participant
@dankamongmen